]> git.ipfire.org Git - thirdparty/linux.git/commit
mm: fix vrealloc()'s KASAN poisoning logic
authorAndrii Nakryiko <andrii@kernel.org>
Tue, 26 Nov 2024 00:52:06 +0000 (16:52 -0800)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 6 Dec 2024 03:54:44 +0000 (19:54 -0800)
commitd699440f58ce9bd71103cc7b692e3ab76a20bfcd
treed1df13e7ab4a4d92c98cb0b0a8580eeba0102abb
parenta220d6b95b1ae12c7626283d7609f0a1438e6437
mm: fix vrealloc()'s KASAN poisoning logic

When vrealloc() reuses already allocated vmap_area, we need to re-annotate
poisoned and unpoisoned portions of underlying memory according to the new
size.

This results in a KASAN splat recorded at [1].  A KASAN mis-reporting
issue where there is none.

Note, hard-coding KASAN_VMALLOC_PROT_NORMAL might not be exactly correct,
but KASAN flag logic is pretty involved and spread out throughout
__vmalloc_node_range_noprof(), so I'm using the bare minimum flag here and
leaving the rest to mm people to refactor this logic and reuse it here.

Link: https://lkml.kernel.org/r/20241126005206.3457974-1-andrii@kernel.org
Link: https://lore.kernel.org/bpf/67450f9b.050a0220.21d33d.0004.GAE@google.com/
Fixes: 3ddc2fefe6f3 ("mm: vmalloc: implement vrealloc()")
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Uladzislau Rezki (Sony) <urezki@gmail.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/vmalloc.c