]> git.ipfire.org Git - thirdparty/qemu.git/commit
qdev: Add cleanup logic in device_set_realized() to avoid resource leak
authorGonglei <arei.gonglei@huawei.com>
Thu, 4 Sep 2014 02:18:26 +0000 (10:18 +0800)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Wed, 24 Dec 2014 21:36:22 +0000 (15:36 -0600)
commitd6af26d6ce544ef50d4114d573a59e54db31fa62
tree185502ed237d69a84a3a5989a0aa66bcc5b1e27c
parent8bb90ee80acea0b5f5ef174edd0033816b927290
qdev: Add cleanup logic in device_set_realized() to avoid resource leak

At present, this function doesn't have partial cleanup implemented,
which will cause resource leaks in some scenarios.

Example:

1. Assume that "dc->realize(dev, &local_err)" executes successful
   and local_err == NULL;
2. device hotplug in hotplug_handler_plug() executes but fails
   (it is prone to occur). Then local_err != NULL;
3. error_propagate(errp, local_err) and return. But the resources
   which have been allocated in dc->realize() will be leaked.
Simple backtrace:
  dc->realize()
   |->device_realize
            |->pci_qdev_init()
                |->do_pci_register_device()
                |->etc.

Add fuller cleanup logic which assures that function can
goto appropriate error label as local_err population is
detected at each relevant point.

Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Andreas Färber <afaerber@suse.de>
(cherry picked from commit 1d45a705fc007a13f20d18473290082eae6d1725)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/core/qdev.c