]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
bnxt_en: reverse order of TX disable and carrier off
authorEdwin Peer <edwin.peer@broadcom.com>
Thu, 11 Feb 2021 07:24:23 +0000 (02:24 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Mar 2021 17:22:39 +0000 (18:22 +0100)
commitd6fe6d183fab3fc1313d7520b0fe8625b84b7d36
treea2432f5583a8518e2dbe03cadd669031f6554a91
parent474ac57c26f7d67c36b349f3bb2f76e9eacaec9f
bnxt_en: reverse order of TX disable and carrier off

[ Upstream commit 132e0b65dc2b8bfa9721bfce834191f24fd1d7ed ]

A TX queue can potentially immediately timeout after it is stopped
and the last TX timestamp on that queue was more than 5 seconds ago with
carrier still up.  Prevent these intermittent false TX timeouts
by bringing down carrier first before calling netif_tx_disable().

Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.")
Signed-off-by: Edwin Peer <edwin.peer@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/broadcom/bnxt/bnxt.c