]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/audio/virtio-snd: fix invalid param check
authorVolker Rümelin <vr_qemu@t-online.de>
Fri, 2 Aug 2024 07:18:05 +0000 (09:18 +0200)
committerMichael Tokarev <mjt@tls.msk.ru>
Fri, 30 Aug 2024 05:18:21 +0000 (08:18 +0300)
commitd73ca551a0c0b16413efe531c978c638d12eb783
treefcc29931abfbc24bab2029139d6abc78ff75a146
parent5a97551d73ae3371d87df35efc5704b2c7daf4dd
hw/audio/virtio-snd: fix invalid param check

Commit 9b6083465f ("virtio-snd: check for invalid param shift
operands") tries to prevent invalid parameters specified by the
guest. However, the code is not correct.

Change the code so that the parameters format and rate, which are
a bit numbers, are compared with the bit size of the data type.

Fixes: 9b6083465f ("virtio-snd: check for invalid param shift operands")
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-Id: <20240802071805.7123-1-vr_qemu@t-online.de>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
(cherry picked from commit 7d14471a121878602cb4e748c4707f9ab9a9e3e2)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/audio/virtio-snd.c