]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/char/bcm2835_aux: Fix assert when receive FIFO fills up
authorFrederik van Hövell <frederik@fvhovell.nl>
Mon, 29 Jul 2024 12:34:18 +0000 (13:34 +0100)
committerMichael Tokarev <mjt@tls.msk.ru>
Fri, 2 Aug 2024 06:37:28 +0000 (09:37 +0300)
commitd73fdbb1d4bada26647c52e9bd54803af81f3073
tree3cf7325600a2c95607a6737e54a6305d054ee74e
parente929b9186ec1e25406cf4f04c5fe1b41bc0b0fe4
hw/char/bcm2835_aux: Fix assert when receive FIFO fills up

When a bare-metal application on the raspi3 board reads the
AUX_MU_STAT_REG MMIO register while the device's buffer is
at full receive FIFO capacity
(i.e. `s->read_count == BCM2835_AUX_RX_FIFO_LEN`) the
assertion `assert(s->read_count < BCM2835_AUX_RX_FIFO_LEN)`
fails.

Reported-by: Cryptjar <cryptjar@junk.studio>
Suggested-by: Cryptjar <cryptjar@junk.studio>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/459
Signed-off-by: Frederik van Hövell <frederik@fvhovell.nl>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
[PMM: commit message tweaks]
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
(cherry picked from commit 546d574b11e02bfd5b15cdf1564842c14516dfab)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/char/bcm2835_aux.c