]> git.ipfire.org Git - thirdparty/qemu.git/commit
block: move drain outside of quorum_del_child()
authorFiona Ebner <f.ebner@proxmox.com>
Fri, 30 May 2025 15:10:53 +0000 (17:10 +0200)
committerKevin Wolf <kwolf@redhat.com>
Wed, 4 Jun 2025 16:16:34 +0000 (18:16 +0200)
commitd75f8ed1d7fc27cf1643e549cd006a68d3bf6ef1
tree03576a4b9840eaa0a78a2ceafd85236e02a0d7bb
parentb13f54654546cbc0661d3fe9d25f7543535c2bee
block: move drain outside of quorum_del_child()

The quorum_del_child() callback runs under the graph lock, so it is
not allowed to drain. It is only called as the .bdrv_del_child()
callback, which is only called in the bdrv_del_child() function, which
also runs under the graph lock.

The bdrv_del_child() function is called by qmp_x_blockdev_change().
A drained section was already introduced there by commit "block: move
drain out of quorum_add_child()".

This finally finishes moving out the drain to places that are not
under the graph lock started in "block: move draining out of
bdrv_change_aio_context() and mark GRAPH_RDLOCK".

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Message-ID: <20250530151125.955508-17-f.ebner@proxmox.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block.c
block/quorum.c
include/block/block_int-common.h