]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
Revert "scsi: core: avoid host-wide host_busy counter for scsi_mq"
authorMing Lei <ming.lei@redhat.com>
Mon, 27 Aug 2018 07:24:43 +0000 (15:24 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 27 Aug 2018 17:17:00 +0000 (13:17 -0400)
commitd772a65d8a6c45c376a8200a38f7f82fb480af6a
treee829a2c4fd245729de1f0920cefaa5d76dd2c758
parent23aa8e69f2c6ceb0bdca52f4450ad1f45675ca73
Revert "scsi: core: avoid host-wide host_busy counter for scsi_mq"

This reverts commit 328728630d9f2bf14b82ca30b5e47489beefe361.

There is fundamental issue in commit 328728630d9f2bf1 (scsi: core: avoid
host-wide host_busy counter for scsi_mq) because SCSI's host busy counter
may not be same with counter of blk-mq's inflight tags, especially in case
of none io scheduler.

We may switch to other approach for addressing this scsi_mq's performance
issue, such as percpu counter or kind of ways, so revert this commit first
for fixing this kind of issue in EH path, as reported by Jens.

Cc: Omar Sandoval <osandov@fb.com>,
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Cc: James Bottomley <james.bottomley@hansenpartnership.com>,
Cc: Christoph Hellwig <hch@lst.de>,
Cc: Don Brace <don.brace@microsemi.com>
Cc: Kashyap Desai <kashyap.desai@broadcom.com>
Cc: Mike Snitzer <snitzer@redhat.com>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Laurence Oberman <loberman@redhat.com>
Cc: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>
Reported-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/hosts.c
drivers/scsi/scsi_lib.c