]> git.ipfire.org Git - people/arne_f/kernel.git/commit
packet: read num_members once in packet_rcv_fanout()
authorEric Dumazet <edumazet@google.com>
Tue, 16 Jun 2015 14:59:11 +0000 (07:59 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Jul 2015 16:49:28 +0000 (09:49 -0700)
commitd7884e43677ba8618ae2f1ead7b96b215b409e20
tree3c9261f8eaeec04a00cfc7ca8a6e15aaf19ff5ed
parent08be544ef5d8453b7778bd57f3da8eeebcf1cd65
packet: read num_members once in packet_rcv_fanout()

[ Upstream commit f98f4514d07871da7a113dd9e3e330743fd70ae4 ]

We need to tell compiler it must not read f->num_members multiple
times. Otherwise testing if num is not zero is flaky, and we could
attempt an invalid divide by 0 in fanout_demux_cpu()

Note bug was present in packet_rcv_fanout_hash() and
packet_rcv_fanout_lb() but final 3.1 had a simple location
after commit 95ec3eb417115fb ("packet: Add 'cpu' fanout policy.")

Fixes: dc99f600698dc ("packet: Add fanout support.")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/packet/af_packet.c