]> git.ipfire.org Git - thirdparty/qemu.git/commit
migration: Fix file migration with fdset
authorFabiano Rosas <farosas@suse.de>
Mon, 17 Jun 2024 18:57:17 +0000 (15:57 -0300)
committerMichael Tokarev <mjt@tls.msk.ru>
Sat, 22 Jun 2024 04:03:13 +0000 (07:03 +0300)
commitd7a4a38a03936a04a27042a7b397ccb4f1b4ff06
tree86b97363fecc39d55900fd14afba77a7d6b82053
parent658fb89bdcbc59217d83c16140446f279c15eaec
migration: Fix file migration with fdset

When the "file:" migration support was added we missed the special
case in the qemu_open_old implementation that allows for a particular
file name format to be used to refer to a set of file descriptors that
have been previously provided to QEMU via the add-fd QMP command.

When using this fdset feature, we should not truncate the migration
file because being given an fd means that the management layer is in
control of the file and will likely already have some data written to
it. This is further indicated by the presence of the 'offset'
argument, which indicates the start of the region where QEMU is
allowed to write.

Fix the issue by replacing the O_TRUNC flag on open by an ftruncate
call, which will take the offset into consideration.

Fixes: 385f510df5 ("migration: file URI offset")
Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Prasad Pandit <pjp@fedoraproject.org>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
(cherry picked from commit 6d3279655ac49b806265f08415165f471d33e032)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
migration/file.c