]> git.ipfire.org Git - thirdparty/qemu.git/commit
virtio-pci: Changed vdev to proxy for VirtIO PCI BAR callbacks.
authorAndrew Melnychenko <andrew@daynix.com>
Mon, 6 Jul 2020 11:21:23 +0000 (14:21 +0300)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Wed, 9 Sep 2020 23:51:39 +0000 (18:51 -0500)
commitd8f0b2bbf4a1ab473c658a56ef5bf3ea57c3c384
treec66806e352adff8ec41ed0d3d864e99b15f1e1d5
parent58c523563dc3146ca4326e20af924abf0b90e9c3
virtio-pci: Changed vdev to proxy for VirtIO PCI BAR callbacks.

There is an issue when callback may be called with invalid vdev.
It happens on unplug when vdev already deleted and VirtIOPciProxy is not.
So now, callbacks accept proxy device, and vdev retrieved from it.
Technically memio callbacks should be removed during the flatview update,
but memoryregions remain til PCI device(and it's address space) completely deleted.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1716352
Signed-off-by: Andrew Melnychenko <andrew@daynix.com>
Message-Id: <20200706112123.971087-1-andrew@daynix.com>
Cc: qemu-stable@nongnu.org
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
(cherry picked from commit ccec7e9603f446fe75c6c563ba335c00cfda6a06)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/virtio/virtio-pci.c