]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Fix problems with NCP and --inetd.
authorGert Doering <gert@greenie.muc.de>
Mon, 22 Aug 2016 20:24:47 +0000 (22:24 +0200)
committerDavid Sommerseth <davids@openvpn.net>
Tue, 23 Aug 2016 10:41:06 +0000 (12:41 +0200)
commitd90249f73353c175ed9e7dd0a450cd084a729e20
treebc5132ac5bb17738a75d677d28db3837de88436c
parente9d64bc03742c96a3d7fe2a473c43d40e5ba2001
Fix problems with NCP and --inetd.

NCP only works with --pull or --mode server, leading to breakage
in --inetd mode (because that has --tls-server, but not --mode server,
but clients can still ask for PUSH_REQUEST).

Fix by turning off o->ncp_enable unless (pull or mode server), and
double-fix by logging an appropriate message and refusing to change
ciphers if the server has already set up its keys.

v2: wrap long msg() text lines

Trac: 715
Signed-off-by: Gert Doering <gert@greenie.muc.de>
Acked-by: Steffan Karger <steffan@karger.me>
Message-Id: 1471897487-8354-1-git-send-email-gert@greenie.muc.de
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg00060.html
Signed-off-by: David Sommerseth <davids@openvpn.net>
src/openvpn/options.c
src/openvpn/push.c