]> git.ipfire.org Git - thirdparty/qemu.git/commit
migration: Return -1 on memory allocation failure in ram.c
authorArun Menon <armenon@redhat.com>
Thu, 18 Sep 2025 15:23:37 +0000 (20:53 +0530)
committerPeter Xu <peterx@redhat.com>
Fri, 3 Oct 2025 13:48:02 +0000 (09:48 -0400)
commitd9d7c8d81398bb45d59cbdf1b4c2ed30f56c733d
tree490cbe51326a2b67605e041d8826cc0dd9a5afe0
parent97c2fad858b521afef1d0aad7b6bb880fbe0fb05
migration: Return -1 on memory allocation failure in ram.c

The function colo_init_ram_cache() currently returns -errno if
qemu_anon_ram_alloc() fails. However, the subsequent cleanup loop that
calls qemu_anon_ram_free() could potentially alter the value of errno.
This would cause the function to return a value that does not accurately
represent the original allocation failure.

This commit changes the return value to -1 on memory allocation failure.
This ensures that the return value is consistent and is not affected by
any errno changes that may occur during the free process.

Reviewed-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Arun Menon <armenon@redhat.com>
Tested-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
Link: https://lore.kernel.org/r/20250918-propagate_tpm_error-v14-20-36f11a6fb9d3@redhat.com
Signed-off-by: Peter Xu <peterx@redhat.com>
migration/ram.c