]> git.ipfire.org Git - thirdparty/git.git/commit
sparse: ignore warning from new glibc headers
authorĐoàn Trần Công Danh <congdanhqx@gmail.com>
Tue, 16 Jul 2024 23:17:41 +0000 (06:17 +0700)
committerJunio C Hamano <gitster@pobox.com>
Wed, 9 Apr 2025 15:42:59 +0000 (08:42 -0700)
commitda87b58014c1673ed8c47a14d315ad5ad4d801db
treeb3dec8c59a88308fc5db31fc1702a923f8f1e368
parent683c54c999c301c2cd6f715c411407c413b1d84e
sparse: ignore warning from new glibc headers

With at least glibc 2.39, glibc provides a function declaration that
matches with this POSIX interface:

    int regexec(const regex_t *restrict preg, const char *restrict string,
           size_t nmatch, regmatch_t pmatch[restrict], int eflags);

such prototype requires variable-length-array for `pmatch'.

Thus, sparse reports this error:

> ../add-patch.c: note: in included file (through ../git-compat-util.h):
> /usr/include/regex.h:682:41: error: undefined identifier '__nmatch'
> /usr/include/regex.h:682:41: error: bad constant expression type
> /usr/include/regex.h:682:41: error: Variable length array is used.

Note: `__nmatch' is POSIX's nmatch.

The glibc's intention is informing their users to provides a large
enough buffer to hold `__nmatch' results and provides diagnosis if
necessary.  It's merely a glibc' implementation detail.

Hide that usage from sparse by using standard C11's macro:
__STDC_NO_VLA__

Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Makefile