]> git.ipfire.org Git - thirdparty/qemu.git/commit
linux-user/armeb: Fix __kernel_cmpxchg() for armeb
authorHelge Deller <deller@gmx.de>
Fri, 28 Jul 2023 19:23:10 +0000 (21:23 +0200)
committerMichael Tokarev <mjt@tls.msk.ru>
Tue, 1 Aug 2023 06:05:03 +0000 (09:05 +0300)
commitdaa3277175e7fd7ec97d2368a35e9804f1870410
tree7b68d011235b56134571c1dc21f3da01e5854a7c
parentd53d3f07dc488961bb9cb074504efdf890603c96
linux-user/armeb: Fix __kernel_cmpxchg() for armeb

Commit 7f4f0d9ea870 ("linux-user/arm: Implement __kernel_cmpxchg with host
atomics") switched to use qatomic_cmpxchg() to swap a word with the memory
content, but missed to endianess-swap the oldval and newval values when
emulating an armeb CPU, which expects words to be stored in big endian in
the guest memory.

The bug can be verified with qemu >= v7.0 on any little-endian host, when
starting the armeb binary of the upx program, which just hangs without
this patch.

Cc: qemu-stable@nongnu.org
Signed-off-by: Helge Deller <deller@gmx.de>
Reported-by: "Markus F.X.J. Oberhumer" <markus@oberhumer.com>
Reported-by: John Reiser <jreiser@BitWagon.com>
Closes: https://github.com/upx/upx/issues/687
Message-Id: <ZMQVnqY+F+5sTNFd@p100>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
(cherry picked from commit 38dd78c41eaf08b490c9e7ec68fc508bbaa5cb1d)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
linux-user/arm/cpu_loop.c