]> git.ipfire.org Git - thirdparty/libvirt.git/commit
Fix logic for assigning PCI addresses to USB2 companion controllers
authorDaniel P. Berrange <berrange@redhat.com>
Mon, 14 May 2012 10:16:22 +0000 (11:16 +0100)
committerCole Robinson <crobinso@redhat.com>
Fri, 15 Jun 2012 14:58:24 +0000 (10:58 -0400)
commitdac6e9a2100e40ed2788f31481d4e924e702da64
tree22887ee2652279c28e807f118738dc6d9e7b7e58
parentb4e9a21c3b568ad4aeed6e90506f6c58172c5b77
Fix logic for assigning PCI addresses to USB2 companion controllers

Currently each USB2 companion controller gets put on a separate
PCI slot. Not only is this wasteful of PCI slots, but it is not
in compliance with the spec for USB2 controllers. The master
echi1 and all companion controllers should be in the same slot,
with echi1 in function 7, and uhci1-3 in functions 0-2 respectively.

* src/qemu/qemu_command.c: Special case handling of USB2 controllers
  to apply correct pci slot assignment
* tests/qemuxml2argvdata/qemuxml2argv-usb-ich9-ehci-addr.args,
  tests/qemuxml2argvdata/qemuxml2argv-usb-ich9-ehci-addr.xml: Expand
  test to cover automatic slot assignment
(cherry picked from commit 1ebd52cb871f87b7868503b28448e96d59e41d63)

Conflicts:

tests/qemuxml2xmltest.c
src/qemu/qemu_command.c
tests/qemuxml2argvdata/qemuxml2argv-usb-ich9-ehci-addr.args
tests/qemuxml2argvdata/qemuxml2argv-usb-ich9-ehci-addr.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-usb-ich9-ehci-addr.xml [new file with mode: 0644]
tests/qemuxml2xmltest.c