]> git.ipfire.org Git - thirdparty/qemu.git/commit
target/i386/cpu: Improve errors for out of bounds property values
authorMarkus Armbruster <armbru@redhat.com>
Thu, 10 Oct 2024 15:01:42 +0000 (17:01 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Fri, 18 Oct 2024 13:03:35 +0000 (15:03 +0200)
commitdac7f90c1ccb717959fb216ace7126be5e3f330a
tree01147d9be8caf2d665562a5519f65c6ddd79d9fd
parentf91cf8175bd40142a2dfddbd8e761b8ca1adc30f
target/i386/cpu: Improve errors for out of bounds property values

The error message for a "stepping" value that is out of bounds is a
bit odd:

    $ qemu-system-x86_64 -cpu qemu64,stepping=16
    qemu-system-x86_64: can't apply global qemu64-x86_64-cpu.stepping=16: Property .stepping doesn't take value 16 (minimum: 0, maximum: 15)

The "can't apply global" part is an unfortunate artifact of -cpu's
implementation.  Left for another day.

The remainder feels overly verbose.  Change it to

    qemu64-x86_64-cpu: can't apply global qemu64-x86_64-cpu.stepping=16: parameter 'stepping' can be at most 15

Likewise for "family", "model", and "tsc-frequency".

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20241010150144.986655-6-armbru@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
target/i386/cpu.c