]> git.ipfire.org Git - thirdparty/git.git/commit
Makefile: consistently use @PLACEHOLDER@ to substitute
authorPatrick Steinhardt <ps@pks.im>
Fri, 6 Dec 2024 13:24:37 +0000 (14:24 +0100)
committerJunio C Hamano <gitster@pobox.com>
Fri, 6 Dec 2024 22:52:08 +0000 (07:52 +0900)
commitdbe46c0feb25417d01267bb97edb861694ed023d
treee2fc4a150cff65824a97cbc1e9f1101594f608fc
parent4638e8806e3a1c5550b9ee3a1201e79cc519b85e
Makefile: consistently use @PLACEHOLDER@ to substitute

We have a bunch of placeholders in our scripts that we replace at build
time, for example by using sed(1). These placeholders come in three
different formats: @PLACEHOLDER@, @@PLACEHOLDER@@ and ++PLACEHOLDER++.

Next to being inconsistent it also creates a bit of a problem with
CMake, which only supports the first syntax in its `configure_file()`
function. To work around that we instead manually replace placeholders
via string operations, which is a hassle and removes safeguards that
CMake has to verify that we didn't forget to replace any placeholders.
Besides that, other build systems like Meson also support the CMake
syntax.

Unify our codebase to consistently use the syntax supported by such
build systems.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
18 files changed:
Makefile
configure.ac
contrib/buildsystems/CMakeLists.txt
git-cvsserver.perl
git-instaweb.sh
git-request-pull.sh
git-send-email.perl
git-sh-i18n.sh
git-sh-setup.sh
git-svn.perl
gitweb/Makefile
gitweb/gitweb.perl
perl/Git/I18N.pm
perl/Git/LoadCPAN.pm
perl/header_templates/fixed_prefix.template.pl
perl/header_templates/runtime_prefix.template.pl
unimplemented.sh
wrap-for-bin.sh