]> git.ipfire.org Git - thirdparty/FORT-validator.git/commit
Delete struct snapshot and struct delta
authorAlberto Leiva Popper <ydahhrk@gmail.com>
Mon, 6 Nov 2023 17:39:12 +0000 (11:39 -0600)
committerAlberto Leiva Popper <ydahhrk@gmail.com>
Mon, 6 Nov 2023 23:09:54 +0000 (17:09 -0600)
commitdc77cf179be4b0c4b2efb532c8d73be4c6587ca1
treede97d7c71d18f6394b3a47f1ea9934871ce3f812
parent604f845ce6b9eb596dc9f1fdff7a7fa5752fcc87
Delete struct snapshot and struct delta

Weird code design.

I originally meant to privatize and de-heap these structures,
but it turns out they were not just used by a single module;
they were only used by `parse_metadata()`.

(Their domain seemed larger than it was, because they were being
initialized elsewhere, for no apparent reason.)

Then, while trying to clean up the global namespace, I noticed that the
hack was actually intertwined with another one: `parse_metadata()` was
being used for two purposes that are never actually used simultaneously.
This cluttered it.

So also separate `parse_metadata()` from `validate_metadata()`.
src/rrdp/rrdp_objects.c
src/rrdp/rrdp_objects.h
src/rrdp/rrdp_parser.c
test/cache/local_cache_test.c