]> git.ipfire.org Git - people/arne_f/kernel.git/commit
md/raid0: fix restore to sector variable in raid0_make_request
authorEric Work <work.eric@gmail.com>
Tue, 19 May 2015 06:26:23 +0000 (23:26 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 6 Jun 2015 15:19:39 +0000 (08:19 -0700)
commitdc82d264943e31b681c28c8398dc094635245bd2
tree7a50d7289a7c872eb0beaf86ca7864e2223d4003
parent41801e3c8024d12cfeacc3be4c79d0dad9a74b46
md/raid0: fix restore to sector variable in raid0_make_request

commit a81157768a00e8cf8a7b43b5ea5cac931262374f upstream.

The variable "sector" in "raid0_make_request()" was improperly updated
by a call to "sector_div()" which modifies its first argument in place.
Commit 47d68979cc968535cb87f3e5f2e6a3533ea48fbd restored this variable
after the call for later re-use.  Unfortunetly the restore was done after
the referenced variable "bio" was advanced.  This lead to the original
value and the restored value being different.  Here we move this line to
the proper place.

One observed side effect of this bug was discarding a file though
unlinking would cause an unrelated file's contents to be discarded.

Signed-off-by: NeilBrown <neilb@suse.de>
Fixes: 47d68979cc96 ("md/raid0: fix bug with chunksize not a power of 2.")
URL: https://bugzilla.kernel.org/show_bug.cgi?id=98501
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/md/raid0.c