]> git.ipfire.org Git - people/arne_f/kernel.git/commit
usb: gadget: lpc32xx_udc: don't dereference ep pointer before null check
authorColin Ian King <colin.king@canonical.com>
Thu, 21 May 2020 15:13:00 +0000 (16:13 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Jun 2020 13:41:54 +0000 (15:41 +0200)
commitdcbdb5f08ec74750ba791dd4801e09c5fb6596bb
tree1bcb494daeb095832e7fc98e38a8bcd568eb1b9a
parent59626dc2cae4e38cf2bf34981cfdea5606925daa
usb: gadget: lpc32xx_udc: don't dereference ep pointer before null check

[ Upstream commit eafa80041645cd7604c4357b1a0cd4a3c81f2227 ]

Currently pointer ep is being dereferenced before it is null checked
leading to a null pointer dereference issue.  Fix this by only assigning
pointer udc once ep is known to be not null.  Also remove a debug
message that requires a valid udc which may not be possible at that
point.

Addresses-Coverity: ("Dereference before null check")
Fixes: 24a28e428351 ("USB: gadget driver for LPC32xx")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/gadget/udc/lpc32xx_udc.c