]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
gdb/python: remove PyObject_IsTrue call in gdbpy_handle_missing_debuginfo
authorAndrew Burgess <aburgess@redhat.com>
Sun, 10 Nov 2024 14:35:22 +0000 (14:35 +0000)
committerAndrew Burgess <aburgess@redhat.com>
Thu, 14 Nov 2024 19:34:43 +0000 (19:34 +0000)
commitdcf4c484539a9ab5fdd0c5ddf43617986480b9bc
treecdc3b0d6d7c767d841ce113e840579ebcf382621
parent768f23b94f3360058cdfa873e75ba563a600e994
gdb/python: remove PyObject_IsTrue call in gdbpy_handle_missing_debuginfo

In this review:

  https://inbox.sourceware.org/gdb-patches/87wmirfzih.fsf@tromey.com

Tom pointed out that using PyObject_IsTrue as I was doing, though
technically fine, at least appears to be missing an error check, and
that it would be better to compare to Py_True directly.  I made that
change in the patch Tom was commenting on, but I'd actually copied
that code from elsewhere in python/python.c, so this commit updates
the original code inline with Tom's review feedback.

There should be no functional change after this commit.

Approved-By: Tom Tromey <tom@tromey.com>
gdb/python/python.c