]> git.ipfire.org Git - thirdparty/git.git/commit
grep: allocate subrepos on heap
authorJonathan Tan <jonathantanmy@google.com>
Mon, 16 Aug 2021 21:09:55 +0000 (14:09 -0700)
committerJunio C Hamano <gitster@pobox.com>
Wed, 8 Sep 2021 18:48:02 +0000 (11:48 -0700)
commitdd45471a3717bcd6561e405371b81928214ad1b5
tree39ff76326814149ad8fd3e06d0e1c62342ef7553
parent78ca584f1c4a720988f6066693b4d2ccde920813
grep: allocate subrepos on heap

Currently, struct repository objects corresponding to submodules are
allocated on the stack in grep_submodule(). This currently works because
they will not be used once grep_submodule() exits, but a subsequent
patch will require these structs to be accessible for longer (perhaps
even in another thread). Allocate them on the heap and clear them only
at the very end.

Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
Reviewed-by: Matheus Tavares <matheus.bernardino@usp.br>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/grep.c