]> git.ipfire.org Git - thirdparty/valgrind.git/commit
Helgrind lock related error msg improvements.
authorPhilippe Waroquiers <philippe.waroquiers@skynet.be>
Tue, 29 Jul 2014 20:08:15 +0000 (20:08 +0000)
committerPhilippe Waroquiers <philippe.waroquiers@skynet.be>
Tue, 29 Jul 2014 20:08:15 +0000 (20:08 +0000)
commitdd6256c0199a955c3a55e02d47407fc5eab07087
tree4ca439a0b755378efdcfa4cde5618b67ae1f5472
parent90e7e07d7e851377ed738285f1ef861f6cf3c319
Helgrind lock related error msg improvements.

* Add lock announcements in various helgrind errors that were not
  announcing the locks
* ensure locks are also announced in xml (note that this is compatible
  with xml protocol version 4, so no impact on GUI which properly
  implement the protocol)

Changes done:
* Like other HG record_error functions, HG_(record_error_LockOrder) is
  now passing Lock* rather than lock guest addresses.
* update exp files for tests that were showing locks without announcing them
* change tc14_laog_dinphils.c and tc15_laog_lockdel.c so as to
  have same sizes on 32 and 64 bits systems for allocated or symbol sizes.
* factorise all code that was announcing first lock observation
* enable xml lock announcement

git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14204
18 files changed:
helgrind/hg_errors.c
helgrind/hg_errors.h
helgrind/hg_main.c
helgrind/tests/annotate_rwlock.stderr.exp
helgrind/tests/hg02_deadlock.stderr.exp
helgrind/tests/locked_vs_unlocked1_fwd.stderr.exp
helgrind/tests/locked_vs_unlocked1_rev.stderr.exp
helgrind/tests/locked_vs_unlocked2.stderr.exp
helgrind/tests/locked_vs_unlocked3.stderr.exp
helgrind/tests/tc09_bad_unlock.stderr.exp
helgrind/tests/tc10_rec_lock.stderr.exp
helgrind/tests/tc12_rwl_trivial.stderr.exp
helgrind/tests/tc13_laog1.stderr.exp
helgrind/tests/tc14_laog_dinphils.c
helgrind/tests/tc14_laog_dinphils.stderr.exp
helgrind/tests/tc15_laog_lockdel.c
helgrind/tests/tc15_laog_lockdel.stderr.exp
helgrind/tests/tc20_verifywrap.stderr.exp