]> git.ipfire.org Git - people/ms/linux.git/commit
hwmon: (smsc47m192) Fix temperature limit and vrm write operations
authorGuenter Roeck <linux@roeck-us.net>
Fri, 18 Jul 2014 14:31:18 +0000 (07:31 -0700)
committerJiri Slaby <jslaby@suse.cz>
Wed, 30 Jul 2014 16:02:41 +0000 (18:02 +0200)
commitdd816b4516f2e50653a43eceb92ca6bb4f562629
tree657993836a71fd4deda71e5960431a862228dccf
parentad8f50f8bd043ca859ad25b6ea66c20713fdae5c
hwmon: (smsc47m192) Fix temperature limit and vrm write operations

commit 043572d5444116b9d9ad8ae763cf069e7accbc30 upstream.

Temperature limit clamps are applied after converting the temperature
from milli-degrees C to degrees C, so either the clamp limit needs
to be specified in degrees C, not milli-degrees C, or clamping must
happen before converting to degrees C. Use the latter method to avoid
overflows.

vrm is an u8, so the written value needs to be limited to [0, 255].

Cc: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/hwmon/smsc47m192.c