]> git.ipfire.org Git - thirdparty/openssl.git/commit
statem: always save sigalgs during PHA
authorBenjamin Kaduk <bkaduk@akamai.com>
Fri, 14 Jun 2024 21:10:39 +0000 (14:10 -0700)
committerTomas Mraz <tomas@openssl.org>
Tue, 1 Apr 2025 13:10:54 +0000 (15:10 +0200)
commitddd99d52d30e2fdae08f9684947cba45ce53898b
treec5e8e691d12cc9b88a282bf400961e31ace928ed
parentdad4704a5dcfa28755822efd802476e4e06acde2
statem: always save sigalgs during PHA

We use the same extension-parsing function on server and client
for convenience, but while the server might worry about tracking
what was previously received and not overwriting it, on the client
receiving a request for post-handshake authentication, we always
want to use the values from the current extension (and should
always have a new session object that we are free to mutate).

It is somewhat unclear whether the server also needs the check
for a resumed connection; it appears to have been added back in
2015 in commit 062178678f5374b09f00d70796f6e692e8775aca as part
of a broad pass to handle extensions on resumption, but without
specific documentation of each extension's handling.

Fixes: #10370
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24651)
ssl/statem/extensions_srvr.c