]> git.ipfire.org Git - people/ms/linux.git/commit
team: don't traverse port list using rcu in team_set_mac_address
authorJiri Pirko <jiri@resnulli.us>
Wed, 4 Mar 2015 07:36:31 +0000 (08:36 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Mar 2015 13:10:52 +0000 (14:10 +0100)
commitdde0b1d5470c7aa302cb82a9565ea626f90d3f28
treea126101227c6ae109e1cf916b980e118731f63d5
parent2391f6b4220bd41b40be920c0f9ed0dc22f914b8
team: don't traverse port list using rcu in team_set_mac_address

[ Upstream commit 9215f437b85da339a7dfe3db6e288637406f88b2 ]

Currently the list is traversed using rcu variant. That is not correct
since dev_set_mac_address can be called which eventually calls
rtmsg_ifinfo_build_skb and there, skb allocation can sleep. So fix this
by remove the rcu usage here.

Fixes: 3d249d4ca7 "net: introduce ethernet teaming device"
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/team/team.c