]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
bpf: wait for running BPF programs when updating map-in-map
authorDaniel Colascione <dancol@google.com>
Fri, 12 Oct 2018 10:54:27 +0000 (03:54 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 13 Nov 2018 19:12:59 +0000 (11:12 -0800)
commitddf734ede053ad9cf1e9555b63cb00dccbf144cf
tree499b6f6fa0a98e0f15e419b6aa9251e75f6a4760
parentbbfed258eb08070e051a1c086282623cc562ff24
bpf: wait for running BPF programs when updating map-in-map

commit 1ae80cf31938c8f77c37a29bbe29e7f1cd492be8 upstream.

The map-in-map frequently serves as a mechanism for atomic
snapshotting of state that a BPF program might record.  The current
implementation is dangerous to use in this way, however, since
userspace has no way of knowing when all programs that might have
retrieved the "old" value of the map may have completed.

This change ensures that map update operations on map-in-map map types
always wait for all references to the old map to drop before returning
to userspace.

Signed-off-by: Daniel Colascione <dancol@google.com>
Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: Chenbo Feng <fengc@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/bpf/syscall.c