]> git.ipfire.org Git - thirdparty/qemu.git/commit
ui: remove unreachable code in vnc_update_client
authorDaniel P. Berrange <berrange@redhat.com>
Mon, 18 Dec 2017 19:12:17 +0000 (19:12 +0000)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Tue, 13 Feb 2018 00:33:28 +0000 (18:33 -0600)
commitde1e7a91c8fdec1527f454e14384653789ba7f1a
tree0a8b8afb4e71fad588ef8c09b055b329c080d039
parent0181686a984ba04406b7b46b283275978ba44ab6
ui: remove unreachable code in vnc_update_client

A previous commit:

  commit 5a8be0f73d6f60ff08746377eb09ca459f39deab
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   Wed Jul 13 12:21:20 2016 +0200

    vnc: make sure we finish disconnect

Added a check for vs->disconnecting at the very start of the
vnc_update_client method. This means that the very next "if"
statement check for !vs->disconnecting always evaluates true,
and is thus redundant. This in turn means the vs->disconnecting
check at the very end of the method never evaluates true, and
is thus unreachable code.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 20171218191228.31018-3-berrange@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
(cherry picked from commit c53df961617736f94731d94b62c2954c261d2bae)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
ui/vnc.c