]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/arm/digic: Mark device with user_creatable = false
authorThomas Huth <thuth@redhat.com>
Mon, 4 Sep 2017 14:21:55 +0000 (15:21 +0100)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Fri, 22 Sep 2017 23:12:26 +0000 (18:12 -0500)
commitde4ad17a8ed674e672c626c5e4b7e27dc82ca55e
tree99c5b1934ce53848106b72dc449e3294eb08c828
parent8a9d7f30636b5ab151f47c7f03b4797bc1408151
hw/arm/digic: Mark device with user_creatable = false

QEMU currently shows some unexpected behavior when the user trys to
do a "device_add digic" on an unrelated ARM machine like integratorcp
in "-nographic" mode (the device_add command does not immediately
return to the monitor prompt), and trying to "device_del" the device
later results in a "qemu/qdev-monitor.c:872:qdev_unplug: assertion
failed: (hotplug_ctrl)" error condition.
Looking at the realize function of the device, it uses serial_hds
directly and this means that the device can not be added a second
time, so let's simply mark it with "user_creatable = false" now.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
(cherry picked from commit f58f25599b72c7479e6a1ff67c7f671823aa14da)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/arm/digic.c