]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
usb: host: fix incorrect updating of offset
authorColin Ian King <colin.king@canonical.com>
Tue, 7 Nov 2017 16:45:04 +0000 (16:45 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 10 Dec 2017 12:40:44 +0000 (13:40 +0100)
commitde667b08c34c61b59fb1a71ba0eff648550a7799
tree457537fb26a9e85ab6067f4ce93d19a1080f54f0
parent15f12be9860e380ccc809f0bb939b9ea385be9b1
usb: host: fix incorrect updating of offset

commit 1d5a31582ef046d3b233f0da1a68ae26519b2f0a upstream.

The variable temp is incorrectly being updated, instead it should
be offset otherwise the loop just reads the same capability value
and loops forever.  Thanks to Alan Stern for pointing out the
correct fix to my original fix.  Fix also cleans up clang warning:

drivers/usb/host/ehci-dbg.c:840:4: warning: Value stored to 'temp'
is never read

Fixes: d49d43174400 ("USB: misc ehci updates")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/ehci-dbg.c