]> git.ipfire.org Git - thirdparty/linux.git/commit
netfilter: nf_conncount: garbage collection is not skipped when jiffies wrap around
authorNicklas Bo Jensen <njensen@akamai.com>
Thu, 27 Feb 2025 13:32:34 +0000 (13:32 +0000)
committerPablo Neira Ayuso <pablo@netfilter.org>
Wed, 5 Mar 2025 21:20:06 +0000 (22:20 +0100)
commitdf08c94baafb001de6cf44bb7098bb557f36c335
tree28028e667fdd10a6b988895b7fec6a42727c521d
parent5cfe5612ca9590db69b9be29dc83041dbf001108
netfilter: nf_conncount: garbage collection is not skipped when jiffies wrap around

nf_conncount is supposed to skip garbage collection if it has already
run garbage collection in the same jiffy. Unfortunately, this is broken
when jiffies wrap around which this patch fixes.

The problem is that last_gc in the nf_conncount_list struct is an u32,
but jiffies is an unsigned long which is 8 bytes on my systems. When
those two are compared it only works until last_gc wraps around.

See bug report: https://bugzilla.netfilter.org/show_bug.cgi?id=1778
for more details.

Fixes: d265929930e2 ("netfilter: nf_conncount: reduce unnecessary GC")
Signed-off-by: Nicklas Bo Jensen <njensen@akamai.com>
Reviewed-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_conncount.c