]> git.ipfire.org Git - thirdparty/qemu.git/commit
block: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode
authorThomas Huth <thuth@redhat.com>
Mon, 14 Jan 2019 13:37:20 +0000 (14:37 +0100)
committerThomas Huth <thuth@redhat.com>
Tue, 22 Jan 2019 05:26:32 +0000 (06:26 +0100)
commitdf71ca84e4dccc8b49233c63c414e0e5e7bcdf0b
tree06437f7b82f6629c89b22321ba434daeee508b25
parent798b858130a92f45540e655253b62ddd733ded8c
block: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode

The header "scsi-lowlevel.h" of libiscsi 1.9.0 contains some bad
"inline" prototype definitions which GCC refuses to compile in its
gnu99 mode:

In file included from block/iscsi.c:52:0:
/usr/include/iscsi/scsi-lowlevel.h:810:13: error: inline function
‘scsi_set_uint16’ declared but never defined [-Werror]
 inline void scsi_set_uint16(unsigned char *c, uint16_t val);
             ^
/usr/include/iscsi/scsi-lowlevel.h:809:13: error: inline function
‘scsi_set_uint32’ declared but never defined [-Werror]
 inline void scsi_set_uint32(unsigned char *c, uint32_t val);
             ^
[...]

This has been fixed by upstream libiscsi in version 1.10.0 (see
https://github.com/sahlberg/libiscsi/commit/7692027d6c11 ), but
since we still want to support 1.9.0 for CentOS 7 / RHEL7, we
have to work-around the issue by redefining the "inline" keyword
to use the old "gnu89" mode behavior via "gnu_inline" instead.

Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
block/iscsi.c