]> git.ipfire.org Git - people/ms/linux.git/commit
xdp: Reset prog in dev_change_xdp_fd when fd is negative
authorDavid Ahern <dsahern@gmail.com>
Sun, 12 Apr 2020 13:32:04 +0000 (07:32 -0600)
committerDaniel Borkmann <daniel@iogearbox.net>
Tue, 14 Apr 2020 19:38:02 +0000 (21:38 +0200)
commitdfa74909cb6b846cbdabfc2c3c7de1d507fca075
treeabcec0eda77f457704330ae51338d22e98d656c9
parent96b2eb6e77959b4b52f80e7a61d03db77606aac6
xdp: Reset prog in dev_change_xdp_fd when fd is negative

The commit mentioned in the Fixes tag reuses the local prog variable
when looking up an expected_fd. The variable is not reset when fd < 0
causing a detach with the expected_fd set to actually call
dev_xdp_install for the existing program. The end result is that the
detach does not happen.

Fixes: 92234c8f15c8 ("xdp: Support specifying expected existing program when attaching XDP")
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Toke Høiland-Jørgensen <toke@redhat.com>
Link: https://lore.kernel.org/bpf/20200412133204.43847-1-dsahern@kernel.org
net/core/dev.c