]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
device property: Fix the length used in PROPERTY_ENTRY_STRING()
authorHeikki Krogerus <heikki.krogerus@linux.intel.com>
Wed, 23 Jan 2019 14:44:16 +0000 (17:44 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 23 Mar 2019 13:35:24 +0000 (14:35 +0100)
commitdfdac22666d229538f499c5d56d38c05b4859f1e
treeb2c7a112f99c8d889f37843e6f4814442c272aa8
parent73a79d1bb2d969e7f05fcb724098073ce661a867
device property: Fix the length used in PROPERTY_ENTRY_STRING()

commit 2b6e492467c78183bb629bb0a100ea3509b615a5 upstream.

With string type property entries we need to use
sizeof(const char *) instead of the number of characters as
the length of the entry.

If the string was shorter then sizeof(const char *),
attempts to read it would have failed with -EOVERFLOW. The
problem has been hidden because all build-in string
properties have had a string longer then 8 characters until
now.

Fixes: a85f42047533 ("device property: helper macros for property entry creation")
Cc: 4.5+ <stable@vger.kernel.org> # 4.5+
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/property.h