]> git.ipfire.org Git - people/arne_f/kernel.git/commit
kvm: don't take vcpu mutex for obviously invalid vcpu ioctls
authorDavid Matlack <dmatlack@google.com>
Fri, 19 Sep 2014 23:03:25 +0000 (16:03 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Oct 2014 16:38:19 +0000 (09:38 -0700)
commitdff6e8cd03a5c2709ef0933e8b48cbf8b28aee4a
treef87165436cd425ecf67a15f3d9b4baf8b9338b28
parenta4095e0bcfb8bade0db43db9c90dd8ee4b62ab13
kvm: don't take vcpu mutex for obviously invalid vcpu ioctls

commit 2ea75be3219571d0ec009ce20d9971e54af96e09 upstream.

vcpu ioctls can hang the calling thread if issued while a vcpu is running.
However, invalid ioctls can happen when userspace tries to probe the kind
of file descriptors (e.g. isatty() calls ioctl(TCGETS)); in that case,
we know the ioctl is going to be rejected as invalid anyway and we can
fail before trying to take the vcpu mutex.

This patch does not change functionality, it just makes invalid ioctls
fail faster.

Signed-off-by: David Matlack <dmatlack@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
virt/kvm/kvm_main.c