]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ALSA: vmaster: Propagate slave error
authorTakashi Iwai <tiwai@suse.de>
Thu, 8 Mar 2018 07:26:48 +0000 (08:26 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 May 2018 05:50:48 +0000 (07:50 +0200)
commite096b3d0f0f4856eeee8ecf02d8a369af939cfda
treea740aaf64220f732fdeda0c54e9e88207c9ac58e
parentb08a3589fb07497cf5d5895a3b6589d0bbfe0156
ALSA: vmaster: Propagate slave error

[ Upstream commit 2e2c177ca84aff092c3c96714b0f6a12900f3946 ]

In slave_update() of vmaster code ignores the error from the slave
get() callback and copies the values.  It's not only about the missing
error code but also that this may potentially lead to a leak of
uninitialized variables when the slave get() don't clear them.

This patch fixes slave_update() not to copy the potentially
uninitialized values when an error is returned from the slave get()
callback, and to propagate the error value properly.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/core/vmaster.c