]> git.ipfire.org Git - thirdparty/vim.git/commit
patch 9.1.0169: current window number returned by tabpagewinnr may be outdated v9.1.0169
authorSean Dewar <6256228+seandewar@users.noreply.github.com>
Tue, 12 Mar 2024 19:42:25 +0000 (20:42 +0100)
committerChristian Brabandt <cb@256bit.org>
Tue, 12 Mar 2024 19:42:25 +0000 (20:42 +0100)
commite101028a5c896480c61fef7ea16855255925709b
tree358b056e76510824f24f7398079a9a3c582e7993
parentbfcc895482c717c9f6d86890d789ec739c3016b4
patch 9.1.0169: current window number returned by tabpagewinnr may be outdated

Problem:  current window number returned by tabpagewinnr may be outdated
          when called from win_execute for the original tabpage.
Solution: update the original tabpage's tp_curwin in switch_win; use
          {un}use_tabpage instead. Don't do it in restore_win to ensure
          tp_curwin of the temporarily visited tabpage is unchanged from
          switch_win visiting it, as before. (Sean Dewar)

Maybe restore_win should only restore tp_curwin if
`curtab == switchwin->sw_curtab`, in case the user changed tabpages from within
win_execute, but not doing that is consistent with the old behaviour.

related: #14186

Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
src/evalwindow.c
src/testdir/test_execute_func.vim
src/version.c