]> git.ipfire.org Git - thirdparty/iptables.git/commit
libiptc: Fix for another segfault due to chain index NULL pointer
authorPhil Sutter <phil@nwl.cc>
Thu, 12 Oct 2023 15:27:42 +0000 (17:27 +0200)
committerPhil Sutter <phil@nwl.cc>
Thu, 12 Oct 2023 15:47:13 +0000 (17:47 +0200)
commite2d7ee9c49b582f399ad4ba2da2ee1b3e1f89620
tree255304667f7f27c3374210d3bd5ff295165fe564
parent8ae55c2a331e932c0aeef8c6c138bf60deb9fd42
libiptc: Fix for another segfault due to chain index NULL pointer

Chain rename code missed to adjust the num_chains value which is used to
calculate the number of chain index buckets to allocate during an index
rebuild. So with the right number of chains present, the last chain in a
middle bucket being renamed (and ending up in another bucket) triggers
an index rebuild based on false data. The resulting NULL pointer index
bucket then causes a segfault upon reinsertion.

Closes: https://bugzilla.netfilter.org/show_bug.cgi?id=1713
Fixes: 64ff47cde38e4 ("libiptc: fix chain rename bug in libiptc")
iptables/tests/shell/testcases/chain/0008rename-segfault2_0 [new file with mode: 0755]
libiptc/libiptc.c