]> git.ipfire.org Git - thirdparty/apache/httpd.git/commit
ap_rgetline_core: fix a bug with folding observed while testing ebcdic.
authorGreg Ames <gregames@apache.org>
Fri, 8 Mar 2002 20:24:07 +0000 (20:24 +0000)
committerGreg Ames <gregames@apache.org>
Fri, 8 Mar 2002 20:24:07 +0000 (20:24 +0000)
commite311cbc704625cc48cc8520a588b12bf97539061
tree7e73bf12836c95c09066623604e9a98b56f9acf3
parentcf13aec945b2031e4c444ab7c6b7735e0171ba7f
ap_rgetline_core: fix a bug with folding observed while testing ebcdic.
Garbage characters sometimes appeared after a legitimate folded header.
We weren't allocating an extra byte for the trailing null, or copying it,
when called from get_mime_headers (folding is in use, and ap_rgetline is
responsible for allocating memory).  No need to worry about a trailing
LF - it's already been nuked.

I checked the partial line code to see if it had a similar bug.  It looked
like it did, and that the code which trims the back end of the line would
run multiple times and whack innocent bytes.  However, gdb showed that this
section of code appears to be dead due to input filter chain changes.

also, removed an assignment to a dead variable.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93804 13f79535-47bb-0310-9956-ffa450edef68
server/protocol.c