]> git.ipfire.org Git - thirdparty/openssl.git/commit
test/wpackettest.c: remove ubogus cleanup() in test_WPACKET_quic_vlint_random()
authorEugene Syromiatnikov <esyr@openssl.org>
Mon, 15 Sep 2025 02:05:04 +0000 (04:05 +0200)
committerNeil Horman <nhorman@openssl.org>
Tue, 16 Sep 2025 13:41:38 +0000 (09:41 -0400)
commite321bc27c73bbd1ecb78d55cbdd5f58e795e5f1a
treeb703c6b79a9e2dee6fe7d70123d568ed60fef4ec
parentdb28045104312c89b57c85be6ce0ca91f193989c
test/wpackettest.c: remove ubogus cleanup() in test_WPACKET_quic_vlint_random()

In the beginning of the iteration, pkt is not initialised yet, so there is
no need to clean it up on RAND_bytes() failure.  Replace "return cleanup(&pkt)"
with plain "return 0"'

Fixes: 416d0a638c16 "QUIC wire format support"
Resolves: https://scan5.scan.coverity.com/#/project-view/65248/10222?selectedIssue=1665422
References: https://github.com/openssl/project/issues/1432
Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28546)
test/wpackettest.c