]> git.ipfire.org Git - thirdparty/dovecot/core.git/commit
lib-smtp: client: Fix assertion panic occurring when DATA dot stream cannot be finish...
authorStephan Bosch <stephan.bosch@dovecot.fi>
Fri, 18 May 2018 08:24:46 +0000 (10:24 +0200)
committerVille Savolainen <ville.savolainen@dovecot.fi>
Mon, 4 Jun 2018 09:59:33 +0000 (12:59 +0300)
commite3dc64746f3d1d9634f6597bb3330930fa6aa357
tree9dada5d12c1b95bcd4279607639ed1fa0a52add3
parent07660d37a51489856be285c4e84fa04c38167f39
lib-smtp: client: Fix assertion panic occurring when DATA dot stream cannot be finished immediately.

If o_stream_finish() returns 0, o_stream_send_istream() would be called again
later which causes the panic. Instead, it should only call o_stream_finish() or
o_stream_flush() again to finish the last bit of the output.

Panic was:

Panic: file ostream.c: line 394 (o_stream_send_istream): assertion failed: (!_outstream->finished)
src/lib-smtp/smtp-client-command.c
src/lib-smtp/smtp-client-private.h