]> git.ipfire.org Git - people/ms/linux.git/commit
projects / people / ms / linux.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 461e743) | patch
panasonic-laptop: avoid overflow in acpi_pcc_hotkey_add()
authorXi Wang <xi.wang@gmail.com>
Thu, 29 Dec 2011 04:49:06 +0000 (23:49 -0500)
committerMatthew Garrett <mjg@redhat.com>
Mon, 12 Mar 2012 14:25:51 +0000 (10:25 -0400)
commite424fb8cc4e6634c10f8159b1ff5618cf7bab9c6
tree1907ba5a04c791b676de548e62627aa50b795bc7tree | snapshot
parent461e74377cfcfc2c0d6bbdfa8fc5fbc21b052c2acommit | diff
panasonic-laptop: avoid overflow in acpi_pcc_hotkey_add()

num_sifr could go negative since acpi_pcc_get_sqty() returns -EINVAL
on error.  Then it could bypass the sanity check (num_sifr > 255).
The subsequent call to kzalloc() would allocate a small buffer, leading
to a memory corruption.

Signed-off-by: Xi Wang <xi.wang@gmail.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
drivers/platform/x86/panasonic-laptop.c diff | blob | blame | history
Michael's Linux tree.