]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix cleanup lock acquisition in SPLIT_ALLOCATE_PAGE replay.
authorAmit Kapila <akapila@postgresql.org>
Mon, 14 Nov 2022 05:02:47 +0000 (10:32 +0530)
committerAmit Kapila <akapila@postgresql.org>
Mon, 14 Nov 2022 05:02:47 +0000 (10:32 +0530)
commite49e191815b6a7fc801e03cf798fb83d3b7f2501
treef1eea12b1b1c7c5605090f9bfea23af9d4ac7985
parentf754e7600a9284b6de8eb78b6b64aa9b46dc80db
Fix cleanup lock acquisition in SPLIT_ALLOCATE_PAGE replay.

During XLOG_HASH_SPLIT_ALLOCATE_PAGE replay, we were checking for a
cleanup lock on the new bucket page after acquiring an exclusive lock on
it and raising a PANIC error on failure. However, it is quite possible
that checkpointer can acquire the pin on the same page before acquiring a
lock on it, and then the replay will lead to an error. So instead, directly
acquire the cleanup lock on the new bucket page during
XLOG_HASH_SPLIT_ALLOCATE_PAGE replay operation.

Reported-by: Andres Freund
Author: Robert Haas
Reviewed-By: Amit Kapila, Andres Freund, Vignesh C
Backpatch-through: 11
Discussion: https://postgr.es/m/20220810022617.fvjkjiauaykwrbse@awork3.anarazel.de
src/backend/access/hash/hash_xlog.c
src/backend/access/hash/hashpage.c