]> git.ipfire.org Git - thirdparty/linux.git/commit
HID: hid-steam: Fix use-after-free when detaching device
authorVicki Pfau <vi@endrift.com>
Thu, 27 Feb 2025 23:41:33 +0000 (15:41 -0800)
committerJiri Kosina <jkosina@suse.com>
Tue, 4 Mar 2025 20:46:12 +0000 (21:46 +0100)
commite53fc232a65f7488ab75d03a5b95f06aaada7262
treee01b7d3daeb68f77fe9d9fb60474b2b13538e372
parenta6a4f4e9b8018806cca30049b59a1c3c8b513701
HID: hid-steam: Fix use-after-free when detaching device

When a hid-steam device is removed it must clean up the client_hdev used for
intercepting hidraw access. This can lead to scheduling deferred work to
reattach the input device. Though the cleanup cancels the deferred work, this
was done before the client_hdev itself is cleaned up, so it gets rescheduled.
This patch fixes the ordering to make sure the deferred work is properly
canceled.

Reported-by: syzbot+0154da2d403396b2bd59@syzkaller.appspotmail.com
Fixes: 79504249d7e2 ("HID: hid-steam: Move hidraw input (un)registering to work")
Signed-off-by: Vicki Pfau <vi@endrift.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/hid-steam.c