]> git.ipfire.org Git - thirdparty/samba.git/commit
tldap_tls: Remove tldap_[gs]et_starttls_needed()
authorVolker Lendecke <vl@samba.org>
Thu, 7 Nov 2024 10:17:12 +0000 (11:17 +0100)
committerVolker Lendecke <vl@samba.org>
Mon, 11 Nov 2024 14:03:03 +0000 (14:03 +0000)
commite54a4f06b31e1cbefcdf3b26c1d36cfa3a9e21e5
tree829268149ac232a94cbe0527b8aeb44bf0b9e2b5
parent2cc41bd6ae1c4136661578e20019f6365f306ca8
tldap_tls: Remove tldap_[gs]et_starttls_needed()

The caller setting up a tldap connection is aware of whether to use
starttls, which is one single ldap extended operation before the tls
crypto starts. There is no complex logic behind this that is
worthwhile to be hidden behind a flag and an API. If there was more to
it than just a simple call to tldap_extended(), I would all be for
passing down that flag, but for this case I would argue the logic
after this patch is simpler.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
source3/include/tldap.h
source3/lib/tldap.c
source3/lib/tldap_tls_connect.c
source3/torture/torture.c
source3/winbindd/idmap_ad.c