]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
usbnet: ipheth: race between ipheth_close and error handling
authorOliver Neukum <oneukum@suse.com>
Tue, 6 Aug 2024 17:28:05 +0000 (19:28 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 9 Aug 2024 12:54:20 +0000 (13:54 +0100)
commite5876b088ba03a62124266fa20d00e65533c7269
tree3292e06d955dcae047ba3409e93d75ffd09d61e9
parentee9a43b7cfe2d8a3520335fea7d8ce71b8cabd9d
usbnet: ipheth: race between ipheth_close and error handling

ipheth_sndbulk_callback() can submit carrier_work
as a part of its error handling. That means that
the driver must make sure that the work is cancelled
after it has made sure that no more URB can terminate
with an error condition.

Hence the order of actions in ipheth_close() needs
to be inverted.

Signed-off-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: Foster Snowhill <forst@pen.gy>
Tested-by: Georgi Valkov <gvalkov@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/ipheth.c