]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
iio: adc: ad_sigma_delta: Fix use of uninitialized status_pos
authorPurva Yeshi <purvayeshi550@gmail.com>
Thu, 10 Apr 2025 17:04:08 +0000 (22:34 +0530)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Tue, 22 Apr 2025 18:10:04 +0000 (19:10 +0100)
commite5cdb098a3cb165d52282ffc3a6448642953ea13
treea0e36f5a2a60c0b26333c5867f17ee12839d72ed
parentb1c5d68ea66e511dfb16cd0e6a730488bd3c3317
iio: adc: ad_sigma_delta: Fix use of uninitialized status_pos

Fix Smatch-detected issue:
drivers/iio/adc/ad_sigma_delta.c:604 ad_sd_trigger_handler() error:
uninitialized symbol 'status_pos'.

The variable `status_pos` was only initialized in specific switch cases
(1, 2, 3, 4), which could leave it uninitialized if `reg_size` had an
unexpected value.

Fix by adding a default case to the switch block to catch unexpected
values of `reg_size`. Use `dev_err_ratelimited()` for error logging and
`goto irq_handled` instead of returning early.

Signed-off-by: Purva Yeshi <purvayeshi550@gmail.com>
Link: https://patch.msgid.link/20250410170408.8585-1-purvayeshi550@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/ad_sigma_delta.c