]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix assertion failure when running pgbench -s.
authorFujii Masao <fujii@postgresql.org>
Thu, 7 Nov 2019 07:31:36 +0000 (16:31 +0900)
committerFujii Masao <fujii@postgresql.org>
Thu, 7 Nov 2019 07:32:37 +0000 (16:32 +0900)
commite5cfb8cbbe91e73ee92d9e4ab023ca208f3b748a
tree15251333fcda436c6df48e347dc65aec35162268
parentf96f14744533e7409876056eeca0229a32fac4dd
Fix assertion failure when running pgbench -s.

If there is the WAL page that the continuation WAL record just fits within
(i.e., the continuation record ends just at the end of the page) and
the LSN in such page is specified with -s option, previously pg_waldump
caused an assertion failure. The cause of this assertion failure was that
XLogFindNextRecord() that pg_waldump -s calls mistakenly handled
such special WAL page.

This commit changes XLogFindNextRecord() so that it can handle
such WAL page correctly.

Back-patch to all supported versions.

Author: Andrey Lepikhov
Reviewed-by: Fujii Masao, Michael Paquier
Discussion: https://postgr.es/m/99303554-5dd5-06e6-f943-b3005ccd6edd@postgrespro.ru
src/backend/access/transam/xlogreader.c