]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu_hotplug: Do not allow absent values in rom settings
authorKristina Hanicova <khanicov@redhat.com>
Wed, 24 Jul 2024 11:02:15 +0000 (13:02 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 24 Jul 2024 11:07:20 +0000 (13:07 +0200)
commite5eb64e9fdf1816c4871a35444495e666900138e
tree7d7327533ee44e03bd59b02b1bfc4edd03b9da26
parentb53e9f834bb5a75f57306a6b704d320f149b7f49
qemu_hotplug: Do not allow absent values in rom settings

If there are absent values in an already existing element
specifying rom settings, we simply use the old ones. This
behaviour is not desired, as users might think that deleting the
element from XML would delete the setting (because the hotplug
succeeds) - which does not happen. Because of that, we should not
accept an interface without elements that cannot be changed.

Therefore, we should not allow absent values for already existing
rom setting during hotplug.

Resolves: https://issues.redhat.com/browse/RHEL-7109
Signed-off-by: Kristina Hanicova <khanicov@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_hotplug.c