]> git.ipfire.org Git - people/ms/linux.git/commit
Makefile: Enable -Warray-bounds
authorKees Cook <keescook@chromium.org>
Sat, 19 Jun 2021 06:30:07 +0000 (23:30 -0700)
committerKees Cook <keescook@chromium.org>
Mon, 14 Feb 2022 00:49:40 +0000 (16:49 -0800)
commite6148767825ce345338328a29030a182e3b22d10
tree12c437c80079caad8c673207996e0aa282e74001
parentdfd42facf1e4ada021b939b4e19c935dcdd55566
Makefile: Enable -Warray-bounds

With the recent fixes for flexible arrays and expanded FORTIFY_SOURCE
coverage, it is now possible to enable -Warray-bounds. Since both GCC
and Clang include -Warray-bounds in -Wall, adjust the Makefile to just
stop disabling it.

Note that this option can be conservative in its warnings (which is
done at casting time rather than access time), but this is reasonable
since the cast variables may be accessed out of a scope where the true
size of the original object can't be evaluated. These handful of false
positives (which are arguably bad casts and can be easily avoided),
are worth dealing with because of the many places where this option
has helped identify missed bounds checks and even accesses done against
cases where a NULL pointer could be reached.

https://github.com/KSPP/linux/issues/109
https://github.com/KSPP/linux/issues/151

Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org
Co-developed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Makefile